Collaborative Tags no longer visible in 25 until user inputs 3 characters

nomad · October 17, 2022, 8:07pm

Here is NC 24 after putting the cursor in the tags field

and here is NC 25

just · October 17, 2022, 9:16pm

github.com/nextcloud/server

Tag loading

nextcloud:master ← nextcloud:bug/noid/tag-loading

opened 02:39PM - 15 Sep 22 UTC

kesselb

+34 -27

If you are a heavy tags user you may run into performance issues. Especially t…he user interface is somewhat unusable with a large number of tags. The tag multi select loads all tags via dav. Filtering is done by select2. I expect the vue migration to fix some of those issues. This PR addresses some low hanging fruits: https://github.com/nextcloud/server/pull/34096/commits/e1d9b0bae20510526b0d00c2afe464945847face: Add minimumInputLength for select2. This will delay the loading of the tags by a few keystrokes. It does not improve the performance but it feels a bit less sluggish. But a minimum input length is also a breaking change and everyone using short tags is probably very unhappy about this :confused: :question: https://github.com/nextcloud/server/pull/34096/commits/1bfac6d0941894677117144519d14f8f3ed455ec: When you start typing tags are fetched via xhr. `fetched` is there to keep track if the data was loaded already. However we have 3 states: not loaded, loading and loaded. If the user continues to type and `fetched` is false another xhr request is started. This commit is here to address the loading state and prevent another xhr request. | Before | After | | --- | --- | | [Screencast from 15.09.2022 12:26:43.webm](https://user-images.githubusercontent.com/3902676/190436318-ed627a6b-49eb-4323-83ac-d5bc409100d5.webm) | [Screencast from 15.09.2022 16:26:20.webm](https://user-images.githubusercontent.com/3902676/190436520-e5cea483-9207-4f4e-bf00-10f1224d70f9.webm) | https://github.com/nextcloud/server/pull/34096/commits/79b4c4f50547232ad3e828be0ac94e9707c46124: It's an optional change. Adding 10k dom elements put some pressure on my browser. I'm not familiar with select2 and the internals however in my tests I noticed that we emit a deprecation warning for each tag. I rewrote getDescriptiveTag and it seems to help a little bit. Add 10k tags via occ: ``` #!/bin/bash for i in {1..10000} do php occ tag:add "Tag$i" "public" done ```

just · October 17, 2022, 9:33pm

github.com/nextcloud/server

Revert minimum length for tags

nextcloud:master ← nextcloud:bug/noid/revert-minimum-lenght-for-tags

opened 09:29PM - 17 Oct 22 UTC

kesselb

+6 -8

Revert https://github.com/nextcloud/server/commit/e1d9b0bae20510526b0d00c2afe464…945847face from https://github.com/nextcloud/server/pull/34096 Joas: > Need to have a submit button then, 3 characters is too long for some languages > (where even names can be a single character) > It' fine to not automatically search, but it needs to be submitable. > Similar like the normal unified search etc Community: > The reason would be that nothing is displayed so you have to click and type three characters (four actions) > with no option to one click on a tag (as before). > It feels like a regression for tag users. Example, a small tag user only needs to see a limited number of tags. > Or, you are simply re-using the same tag over and over. https://help.nextcloud.com/t/collaborative-tags-no-longer-visible-in-25-until-user-inputs-3-characters/147647

nomad · October 20, 2022, 7:13am

Thanks a lot, this change hasn’t made it into the NC 25 stable release, though. Let’s hope it will get merged soon.

nomad · November 3, 2022, 6:32pm

Unfortunately no progress here, it hasn’t made it into 25.0.1 either, maybe the devs don’t want to revert

just · November 3, 2022, 10:19pm

Ask on the pull request for an eta as opposed to posting here @nomad

nomad · November 5, 2022, 9:02am

done, thanks!

nomad · December 9, 2022, 9:39pm

Now with NC 25.0.2 the tags feature is working again and I can browse through all tags again, thanks a lot Nextcloud!