Hi,
I have modified the email app to use fulltextsearch as the underlying search engine if it’s installed. It supports searching attachments too. I have it working on my local server, and it really improves the email search experience.
But I don’t know how to make this available as a pull request. It required some changes on the mail, fulltextsearch and fulltextsearch_elasticsearch repos and there are a bunch of different branches on each, so I don’t know if I’ve targeted the correct versions.
Is there any guidance on how the branch structure work?
Should requesting PR’s for these kinds of enhancements on main branch or the latest release?Any pointers would be appreciated.
Regards,
Frank.
Hello and welcome to the forums @hagenson!
First a small advice: many devs are not actively monitoring the forum. Thus, I fear, you will not reach the maintainers of all apps here. However, some come along from time to time. Most work mainly on GitHub issues. No problem just general information.
Many apps (but not all, this is no hard requirement) use one master or main branch to have the most recent features. On top, there are stableXX branches that mirror the individual server releases (e.g. stable32 is for NC 32). Bugs and new features are backported if possible. If a branch is not easily updatable, the feature is not available on that NC version. Development happens on individual branches that are merged onto master. That is the operation method for all repos I have seen so far. No guarantee there is no exception but I guess this is a starting point.
Is it possible to separate your changes into chunks that make (atomically) sense? Like “allow new type of notifications”? Then, I would start with them to get it in.
One word of warning: you will need a long time to have this all delivered. If you need to change apps part of the server, you have to keep the server releases in mind: every 6 months one new major release and they are kept backward compatible for at least 2 versions (community) and maybe 10 (?)(enterprise). So, you might need to wait 1 year (!) for the brand new notification feature to be out on guaranteed level for community.
Either you wait each time significant amounts of time or you manage to make your changes robust enough that the code can enable the features one all requirements are satisfied.
I do not want to stop you. In contrast, you should bring in your suggestions. But I want to avoid the wrong assumption to have this rolling within 2 days or so.
Chris
Thanks Chris,
yes the changes make sense individually.
That is good information to get me started.
I had assumed it would take a while to get everything in.
I built this stuff my own use, but it just works so well I thought I should try and give something back.
I’ll see how I get on.
Thanks,
Frank.