Only variables should be passed by reference at ../apps/memories/lib/Db/TimelineWritePlaces.php#53

chrissi55 · July 3, 2023, 5:59am

After having memories app again up and running i see the following errors in my nextcloud log:

Fehler PHP Only variables should be passed by reference at /var/www/nextcloud/apps/memories/lib/Db/TimelineWritePlaces.php#53

detailed:
[PHP] Fehler: Only variables should be passed by reference at /var/www/nextcloud/apps/memories/lib/Db/TimelineWritePlaces.php#53

MOVE /remote.php/dav/uploads/USERNAME/50fb67ebdf4cb10174671e8ed0832f1a/.file
from CLIENT-IP by USERNAME at 2023-07-03T05:02:36+02:00

I reproduced that the errors occur when uploading image files to nextcloud via feature “automatic upload” offered by the e.g. nextcloud android app (my version 3.25.0 from GPlay)

The error does not occur when uploading pics e.g. via WebUI in browser.

Can anyone give a hint what goes wrong.
It’s the first time i see those errors.
The pictures are stored in nextcloud under “SofortUpload/subfolder/subfolder…” so in the destinated space. I set automatic upload to create own folders → sorted by year and month

A Bug report is generated

github.com/pulsejet/memories

Only variables should be passed by reference at ../apps/memories/lib/Db/TimelineWritePlaces.php#53

opened 01:48PM - 03 Jul 23 UTC

chrissi55

needs triage

**Describe the bug** After update from memories app 5.1.0 to 5.2.0 i see following log entries ``` Fehler PHP Only variables should be passed by reference at /var/www/nextcloud/apps/memories/lib/Db/TimelineWritePlaces.php#53 detailed: [PHP] Fehler: Only variables should be passed by reference at /var/www/nextcloud/apps/memories/lib/Db/TimelineWritePlaces.php#53 MOVE /remote.php/dav/uploads/USERNAME/50fb67ebdf4cb10174671e8ed0832f1a/.file from CLIENT-IP by USERNAME at 2023-07-03T05:02:36+02:00 ``` **To Reproduce** Use Memories app in Nextcloud 26.0.3 in version 5.2.0 Use an Android device e.g. Android 13 Phone and use the nextcloud client app from the play store in version 3.25.0. Edit the settings in the android app if not already set and use the "automatic upload" feature that offers a method to upload newly taken photos via webdav to your nextcloud destination folder for uploads. Use the feature that photos are sorted by year and month directly and the feature to create new month folders if not exist. Let the upload work and see the entries as seen above in NC log for each photo that is uploaded comes a new error message. So if you have some pics the syslog of your nextcloud is maybe flooded by those messages. **Screenshots** no errors on the client side / user side to make screenshots of. Photos reach their destinated spaces on NC server. Only the syslog is flooded see above. **Platform:** - OS: [e.g. iOS] Android 13 - Browser: [e.g. Chrome, Safari] Nextcloud Client 3.25.0 - Memories Version: [e.g. 4.1.0] 5.2.0 - Nextcloud Version: [e.g. 25.0.6] 26.0.3 - PHP Version: [e.g. 8.1] php8.2-fpm / NGinx **Additional context** .. - Any errors in the JS console? not seen yet - Any errors in the Nextcloud server logs? yes, as copied above

chrissi55 · July 4, 2023, 4:53am

The solution published on github solved my problem, many thanks