OCP event before file delete?

maxxer · December 14, 2020, 4:36pm

Hi.
I’d like to develop an app to prevent the deletion of some files, either via web or client. I was looking at preDelete hook but I read in the docs it’s being deprecated. Unfortunately I couldn’t find the corresponding event in OCP ones. Did I miss something or shall I stick with hooks?

Thanks

kesselb · December 14, 2020, 5:00pm

Hi @maxxer,

github.com

nextcloud/server/blob/6aa6ab3e02c1ab50992c824b85ecc1a45988379c/lib/private/Files/Node/HookConnector.php#L140-L148


	public function delete($arguments) {
		$node = $this->getNodeForPath($arguments['path']);
		$this->deleteMetaCache[$node->getPath()] = $node->getFileInfo();
		$this->root->emit('\OC\Files', 'preDelete', [$node]);
		$this->legacyDispatcher->dispatch('\OCP\Files::preDelete', new GenericEvent($node));
		$event = new BeforeNodeDeletedEvent($node);
		$this->dispatcher->dispatchTyped($event);
	}

Try OCP\Files\Events\Node\BeforeNodeDeletedEvent . A lot of code is still using the deprecated hooks. Much work to migrate everything.

ChristophWurst · December 15, 2020, 10:30am

Yep, that’s the one. Apparently they are still not documented: https://github.com/nextcloud/server/pull/20597#event-3260601968