Issues after uprading to 25.0.1

M.Kuhnla · November 4, 2022, 2:15pm

Hi there,
after upgrading to 25.0.1 on my NC instance running on TrueNas (FreeBSD 13), I get some weird problems:

Klicking for example in Admin->Overview leads to an internal error

Watching the logfile (occ log:watch) shows, NC has problems with LocalAddressChecker.php
Error index Exception: strpos() expects parameter 1 to be string, bool 2022-11-04T14:04:41+00:00
given in file
‘/usr/local/www/nextcloud/lib/private/Http/Client/LocalAddressChecker.php’

                          line 82 at lib/private/AppFramework/Http/Dispatcher.php line
                          165

                          0. .../App.php line 172
                             OC\AppFramework\Http\Dispatcher->dispatch(

                             )
                          1. .../Route/Router.php line 298
                             OC\AppFramework\App::main(

                             )
                          2. lib/base.php line 1047
                             OC\Route\Router->match(

                             )
                          3. index.php line 36
                             OC::handleRequest(

                             )

                          Caused by TypeError: strpos() expects parameter 1 to be string, bool

                          given at lib/private/Http/Client/LocalAddressChecker.php line
                          82

                           0. .../Http/Client/LocalAddressChecker.php line 82
                              strpos(

                              )
                           1. .../Client.php line 184
                              OC\Http\Client\LocalAddressChecker->ThrowIfLocalAddress(

                              )
                           2. .../Client.php line 217
                              OC\Http\Client\Client->preventLocalAddress(

                              )
                           3. .../VersionCheck.php line 131
                              OC\Http\Client\Client->get(

                              )
                           4. .../VersionCheck.php line 92
                              OC\Updater\VersionCheck->getUrlContent(

                              )
                           5. .../UpdateChecker.php line 52
                              OC\Updater\VersionCheck->check(

                              )
                           6. .../Admin.php line 95
                              OCA\UpdateNotification\UpdateChecker->getUpdateState(

                              )
                           7. .../CommonSettingsTrait.php line 129
                              OCA\UpdateNotification\Settings\Admin->getForm(

                              )
                           8. .../AdminSettingsController.php line 83
                              OCA\Settings\Controller\AdminSettingsController->formatSettings(


                              )
                           9. .../CommonSettingsTrait.php line 149
                              OCA\Settings\Controller\AdminSettingsController->getSettings(


                              )
                          10. .../AdminSettingsController.php line 68
                              OCA\Settings\Controller\AdminSettingsController->getIndexResponse(


                              )
                          11. .../Dispatcher.php line 225
                              OCA\Settings\Controller\AdminSettingsController->index(

                              )
                          12. .../Dispatcher.php line 133
                              OC\AppFramework\Http\Dispatcher->executeController(

                              )
                          13. .../App.php line 172
                              OC\AppFramework\Http\Dispatcher->dispatch(

                              )
                          14. .../Route/Router.php line 298
                              OC\AppFramework\App::main(

                              )
                          15. lib/base.php line 1047
                              OC\Route\Router->match(

                              )
                          16. index.php line 36
                              OC::handleRequest(

                              )

In file lib/private/Http/Client/LocalAddressChecker.php I found, that $host = idn_to_utf8(strtolower(urldecode($host))); returns false and not a string.

Any idea whats wrong here?

Regards and kudos for the great release
Markus

M.Kuhnla · November 5, 2022, 11:33am

I found a solution bymyself.

I downloaded a fresh source zip (latest.zip) and switched my installation to this fresh set of files.

No more errors from now.

I do not understand why this helped but it did so far.

Thanks for reading
Markus

tflidd · February 12, 2023, 2:16pm

Did you use the updater app in the first place? And then just using the code of the zip-archive solved the issue?

I had the same issue updateing to 24.0.9, not sure if they are linked. I’m also running on a FreeBSD system (version 12). On 24.0.7 I didn’t have the problem.

I’m running a test setup on the same server with NC 25.0.4RC1.

I created a bug report

github.com/nextcloud/server

[Bug]: After update to 24.0.9: Argument #1 ($haystack) must be of type string, bool given in lib/private/Http/Client/LocalAddressChecker.php

opened 10:50AM - 11 Feb 23 UTC

tflidd

bug 0. Needs triage 24-feedback

### ⚠️ This issue respects the following points: ⚠️ - [X] This is a **bug**, …not a question or a configuration/webserver/proxy issue. - [X] This issue is **not** already reported on Github _(I've searched it)_. - [X] Nextcloud Server **is** up to date. See [Maintenance and Release Schedule](https://github.com/nextcloud/server/wiki/Maintenance-and-Release-Schedule) for supported versions. - [X] Nextcloud Server **is** running on 64bit capable CPU, PHP and OS. - [X] I agree to follow Nextcloud's [Code of Conduct](https://nextcloud.com/contribute/code-of-conduct/). ### Bug description I updated nextcloud from 24.0.7 (I think, or 24.0.6) to the latest 24.0.9. After running through the update procedure, I can provide my password at login, but when it should ask for 2FA, it comes with a Internal server error. In the logs (enormous line), I get a "strpos(): Argument #1 ($haystack) must be of type string, bool given" error. It seems to be linked to my test-setup that runs on the same host on a different virtual host (and different subdomain). I use federated shares between the instances which might cause the issue somehow. The testsetup has now the same issue (was on NC 25.0.1), I upgraded the testsetup to the 25.0.4RC1. It doesn't change anything. Now I put the testsetup in maintenance mode, still the same error. ### Steps to reproduce 1. Use two setups on different subdomain on the same host (ip address) 2. Update to 24.0.9 ### Expected behavior Not having this error? ### Installation method Community Manual installation with Archive ### Operating system Other ### PHP engine version PHP 8.1 ### Web server Nginx ### Database engine version MariaDB ### Is this bug present after an update or on a fresh install? Updated from a minor version (ex. 22.2.3 to 22.2.4) ### Are you using the Nextcloud Server Encryption module? Encryption is Disabled ### What user-backends are you using? - [X] Default user-backend _(database)_ - [ ] LDAP/ Active Directory - [ ] SSO - SAML - [ ] Other ### Configuration report ```shell { "system": { "installed": true, "dbtype": "mysql", "dbname": "***REMOVED SENSITIVE VALUE***", "dbuser": "***REMOVED SENSITIVE VALUE***", "dbpassword": "***REMOVED SENSITIVE VALUE***", "dbhost": "***REMOVED SENSITIVE VALUE***", "dbtableprefix": "", "forcessl": true, "blacklisted_files": [ ".htaccess" ], "allow_user_to_change_display_name": true, "updatechecker": false, "has_internet_connection": true, "enablebackup": false, "datadirectory": "***REMOVED SENSITIVE VALUE***", "version": "24.0.9.2", "installedat": "1325006970.14", "lastupdatedat": "1329928732.51", "loglevel": 1, "logdateformat": "F d, Y H:i:s", "log_rotate_size": 100000000, "instanceid": "***REMOVED SENSITIVE VALUE***", "maintenance": false, "theme": "", "trusted_domains": [ "example.com", "example.com", "example.com" ], "asset-pipeline.enabled": false, "overwritewebroot": "\/", "htaccess.RewriteBase": "\/", "mail_from_address": "***REMOVED SENSITIVE VALUE***", "mail_smtpmode": "sendmail", "mail_domain": "***REMOVED SENSITIVE VALUE***", "secret": "***REMOVED SENSITIVE VALUE***", "activity_expire_days": 90, "memcache.local": "\\OC\\Memcache\\APCu", "memcache.locking": "\\OC\\Memcache\\Redis", "redis": { "host": "***REMOVED SENSITIVE VALUE***", "port": 0 }, "trashbin_retention_obligation": "auto, 200", "mysql.utf8mb4": true, "mail_smtpauthtype": "LOGIN", "updater.release.channel": "stable", "mail_sendmailmode": "pipe", "overwrite.cli.url": "https:\/\/example.com" } } ``` ### List of activated Apps ```shell Enabled: - accessibility: 1.10.0 - activity: 2.16.0 - admin_audit: 1.14.0 - announcementcenter: 6.3.1 - apporder: 0.15.0 - audioplayer: 3.3.1 - bookmarks: 11.0.4 - calendar: 3.5.5 - camerarawpreviews: 0.8.1 - checksum: 1.2.0 - circles: 24.0.1 - cloud_federation_api: 1.7.0 - comments: 1.14.0 - contacts: 4.2.4 - contactsinteraction: 1.5.0 - dav: 1.22.0 - deck: 1.7.3 - federatedfilesharing: 1.14.0 - federation: 1.14.0 - files: 1.19.0 - files_accesscontrol: 1.14.1 - files_automatedtagging: 1.14.0 - files_external: 1.16.1 - files_pdfviewer: 2.5.0 - files_rightclick: 1.3.0 - files_sharing: 1.16.2 - files_trashbin: 1.14.0 - files_versions: 1.17.0 - files_videoplayer: 1.13.0 - firstrunwizard: 2.13.0 - forms: 2.5.1 - gpxpod: 4.3.0 - lookup_server_connector: 1.12.0 - news: 20.0.1 - nextcloud_announcements: 1.13.0 - notifications: 2.12.1 - oauth2: 1.12.0 - password_policy: 1.14.0 - photos: 1.6.0 - polls: 3.8.4 - privacy: 1.8.0 - provisioning_api: 1.14.0 - recommendations: 1.3.0 - serverinfo: 1.14.0 - settings: 1.6.0 - sharebymail: 1.14.0 - spreed: 14.0.8 - survey_client: 1.12.0 - systemtags: 1.14.0 - tasks: 0.14.5 - text: 3.5.1 - theming: 1.15.0 - twofactor_backupcodes: 1.13.0 - twofactor_totp: 6.4.1 - updatenotification: 1.14.0 - user_status: 1.4.0 - viewer: 1.8.0 - workflowengine: 2.6.0 ``` ### Nextcloud Signing status ```shell I cannot login! If I run "php occ integrity:check-core" it just returns nothing (no error, but no ok either) ``` ### Nextcloud Logs ```shell { "reqId": "FOygCZuiHSXNIt0GPl8v", "level": 3, "time": "February 11, 2023 09:55:30", "remoteAddr": "IPADDR", "user": "USERNAME", "app": "index", "method": "POST", "url": "/index.php", "message": "strpos(): Argument #1 ($haystack) must be of type string, bool given in file '/usr/local/www/nextcloud/lib/private/Http/Client/LocalAddressChecker.php' line 82", "userAgent": "Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:109.0) Gecko/20100101 Firefox/109.0", "version": "24.0.9.2", "exception": { "Exception": "Exception", "Message": "strpos(): Argument #1 ($haystack) must be of type string, bool given in file '/usr/local/www/nextcloud/lib/private/Http/Client/LocalAddressChecker.php' line 82", "Code": 0, "Trace": [ { "file": "/usr/local/www/nextcloud/lib/private/AppFramework/App.php", "line": 172, "function": "dispatch", "class": "OC\\AppFramework\\Http\\Dispatcher", "type": "->", "args": [ { "__class__": "OC\\Core\\Controller\\LoginController" }, "tryLogin" ] }, { "file": "/usr/local/www/nextcloud/lib/private/Route/Router.php", "line": 298, "function": "main", "class": "OC\\AppFramework\\App", "type": "::", "args": [ "OC\\Core\\Controller\\LoginController", "tryLogin", { "__class__": "OC\\AppFramework\\DependencyInjection\\DIContainer" }, [ "core.login.tryLogin" ] ] }, { "file": "/usr/local/www/nextcloud/lib/base.php", "line": 1030, "function": "match", "class": "OC\\Route\\Router", "type": "->", "args": [ "/login" ] }, { "file": "/usr/local/www/nextcloud/index.php", "line": 36, "function": "handleRequest", "class": "OC", "type": "::", "args": [] } ], "File": "/usr/local/www/nextcloud/lib/private/AppFramework/Http/Dispatcher.php", "Line": 165, "Previous": { "Exception": "TypeError", "Message": "strpos(): Argument #1 ($haystack) must be of type string, bool given", "Code": 0, "Trace": [ { "file": "/usr/local/www/nextcloud/lib/private/Http/Client/LocalAddressChecker.php", "line": 82, "function": "strpos", "args": [ "*** sensitive parameters replaced ***", "[" ] }, { "file": "/usr/local/www/nextcloud/lib/private/Http/Client/Client.php", "line": 184, "function": "ThrowIfLocalAddress", "class": "OC\\Http\\Client\\LocalAddressChecker", "type": "->", "args": [ "https://testsetup.example.com/ocs-provider/" ] }, { "file": "/usr/local/www/nextcloud/lib/private/Http/Client/Client.php", "line": 217, "function": "preventLocalAddress", "class": "OC\\Http\\Client\\Client", "type": "->", "args": [ "https://testsetup.example.com/ocs-provider/", [ 10, 10 ] ] }, { "file": "/usr/local/www/nextcloud/lib/private/OCS/DiscoveryService.php", "line": 85, "function": "get", "class": "OC\\Http\\Client\\Client", "type": "->", "args": [ "https://testsetup.example.com/ocs-provider/", [ 10, 10 ] ] }, { "file": "/usr/local/www/nextcloud/apps/files_sharing/lib/External/Storage.php", "line": 88, "function": "discover", "class": "OC\\OCS\\DiscoveryService", "type": "->", "args": [ "https://testsetup.example.com", "FEDERATED_SHARING" ] }, { "file": "/usr/local/www/nextcloud/lib/private/Files/Mount/MountPoint.php", "line": 167, "function": "__construct", "class": "OCA\\Files_Sharing\\External\\Storage", "type": "->", "args": [ [ "https://testsetup.example.com/", "18DXT2hsvEto69J", "", "/username/files/share_folder", "*** sensitive parameters replaced ***", "And 5 more entries, set log level to debug to see all entries" ] ] }, { "file": "/usr/local/www/nextcloud/lib/private/Files/Mount/MountPoint.php", "line": 192, "function": "createStorage", "class": "OC\\Files\\Mount\\MountPoint", "type": "->", "args": [] }, { "file": "/usr/local/www/nextcloud/lib/private/Files/Config/UserMountCache.php", "line": 88, "function": "getStorage", "class": "OC\\Files\\Mount\\MountPoint", "type": "->", "args": [] }, { "function": "OC\\Files\\Config\\{closure}", "class": "OC\\Files\\Config\\UserMountCache", "type": "->", "args": [ "*** sensitive parameters replaced ***" ] }, { "file": "/usr/local/www/nextcloud/lib/private/Files/Config/UserMountCache.php", "line": 89, "function": "array_filter", "args": [ [ { "__class__": "OC\\Files\\Mount\\MountPoint" }, "*** sensitive parameters replaced ***", { "__class__": "OCA\\Files_Sharing\\SharedMount" }, { "__class__": "OCA\\Files_Sharing\\SharedMount" } ], { "__class__": "Closure" } ] }, { "file": "/usr/local/www/nextcloud/lib/private/Files/SetupManager.php", "line": 292, "function": "registerMounts", "class": "OC\\Files\\Config\\UserMountCache", "type": "->", "args": [ "*** sensitive parameters replaced ***", [ { "__class__": "OC\\Files\\Mount\\MountPoint" }, "*** sensitive parameters replaced ***", { "__class__": "OCA\\Files_Sharing\\SharedMount" }, { "__class__": "OCA\\Files_Sharing\\SharedMount" } ], [ "OC\\Files\\Mount\\CacheMountProvider", "OCA\\Files_External\\Config\\ConfigAdapter", "OCA\\Files_Sharing\\MountProvider", "OCA\\Files_Sharing\\External\\MountProvider" ] ] }, { "file": "/usr/local/www/nextcloud/lib/private/Files/SetupManager.php", "line": 228, "function": "afterUserFullySetup", "class": "OC\\Files\\SetupManager", "type": "->", "args": [ "*** sensitive parameters replaced ***", [] ] }, { "file": "/usr/local/www/nextcloud/lib/private/Files/Filesystem.php", "line": 379, "function": "setupForUser", "class": "OC\\Files\\SetupManager", "type": "->", "args": [ "*** sensitive parameters replaced ***" ] }, { "file": "/usr/local/www/nextcloud/lib/private/Cache/File.php", "line": 57, "function": "initMountPoints", "class": "OC\\Files\\Filesystem", "type": "::", "args": [ "*** sensitive parameters replaced ***" ] }, { "file": "/usr/local/www/nextcloud/lib/private/Cache/File.php", "line": 178, "function": "getStorage", "class": "OC\\Cache\\File", "type": "->", "args": [] }, { "file": "/usr/local/www/nextcloud/lib/base.php", "line": 838, "function": "gc", "class": "OC\\Cache\\File", "type": "->", "args": [] }, { "function": "{closure}", "class": "OC", "type": "::", "args": [ "*** sensitive parameters replaced ***" ] }, { "file": "/usr/local/www/nextcloud/lib/private/Hooks/EmitterTrait.php", "line": 106, "function": "call_user_func_array", "args": [ { "__class__": "Closure" }, [ "*** sensitive parameters replaced ***", "*** sensitive parameters replaced ***", "*** sensitive parameters replaced ***", "*** sensitive parameters replaced ***" ] ] }, { "file": "/usr/local/www/nextcloud/lib/private/Hooks/PublicEmitter.php", "line": 40, "function": "emit", "class": "OC\\Hooks\\BasicEmitter", "type": "->", "args": [ "\\OC\\User", "postLogin", [ "*** sensitive parameters replaced ***", "*** sensitive parameters replaced ***", "*** sensitive parameters replaced ***", "*** sensitive parameters replaced ***" ] ] }, { "file": "/usr/local/www/nextcloud/lib/private/User/Session.php", "line": 400, "function": "emit", "class": "OC\\Hooks\\PublicEmitter", "type": "->", "args": [ "\\OC\\User", "postLogin", [ "*** sensitive parameters replaced ***", "*** sensitive parameters replaced ***", "*** sensitive parameters replaced ***", "*** sensitive parameters replaced ***" ] ] }, { "file": "/usr/local/www/nextcloud/lib/private/Authentication/Login/CompleteLoginCommand.php", "line": 44, "function": "completeLogin", "class": "OC\\User\\Session", "type": "->", "args": [ "*** sensitive parameters replaced ***" ] }, { "file": "/usr/local/www/nextcloud/lib/private/Authentication/Login/ALoginCommand.php", "line": 40, "function": "process", "class": "OC\\Authentication\\Login\\CompleteLoginCommand", "type": "->", "args": [ { "__class__": "OC\\Authentication\\Login\\LoginData" } ] }, { "file": "/usr/local/www/nextcloud/lib/private/Authentication/Login/LoggedInCheckCommand.php", "line": 60, "function": "processNextOrFinishSuccessfully", "class": "OC\\Authentication\\Login\\ALoginCommand", "type": "->", "args": [ { "__class__": "OC\\Authentication\\Login\\LoginData" } ] }, { "file": "/usr/local/www/nextcloud/lib/private/Authentication/Login/ALoginCommand.php", "line": 40, "function": "process", "class": "OC\\Authentication\\Login\\LoggedInCheckCommand", "type": "->", "args": [ { "__class__": "OC\\Authentication\\Login\\LoginData" } ] }, { "file": "/usr/local/www/nextcloud/lib/private/Authentication/Login/EmailLoginCommand.php", "line": 70, "function": "processNextOrFinishSuccessfully", "class": "OC\\Authentication\\Login\\ALoginCommand", "type": "->", "args": [ { "__class__": "OC\\Authentication\\Login\\LoginData" } ] }, { "file": "/usr/local/www/nextcloud/lib/private/Authentication/Login/ALoginCommand.php", "line": 40, "function": "process", "class": "OC\\Authentication\\Login\\EmailLoginCommand", "type": "->", "args": [ { "__class__": "OC\\Authentication\\Login\\LoginData" } ] }, { "file": "/usr/local/www/nextcloud/lib/private/Authentication/Login/UidLoginCommand.php", "line": 54, "function": "processNextOrFinishSuccessfully", "class": "OC\\Authentication\\Login\\ALoginCommand", "type": "->", "args": [ { "__class__": "OC\\Authentication\\Login\\LoginData" } ] }, { "file": "/usr/local/www/nextcloud/lib/private/Authentication/Login/ALoginCommand.php", "line": 40, "function": "process", "class": "OC\\Authentication\\Login\\UidLoginCommand", "type": "->", "args": [ { "__class__": "OC\\Authentication\\Login\\LoginData" } ] }, { "file": "/usr/local/www/nextcloud/lib/private/Authentication/Login/UserDisabledCheckCommand.php", "line": 58, "function": "processNextOrFinishSuccessfully", "class": "OC\\Authentication\\Login\\ALoginCommand", "type": "->", "args": [ { "__class__": "OC\\Authentication\\Login\\LoginData" } ] }, { "file": "/usr/local/www/nextcloud/lib/private/Authentication/Login/ALoginCommand.php", "line": 40, "function": "process", "class": "OC\\Authentication\\Login\\UserDisabledCheckCommand", "type": "->", "args": [ { "__class__": "OC\\Authentication\\Login\\LoginData" } ] }, { "file": "/usr/local/www/nextcloud/lib/private/Authentication/Login/PreLoginHookCommand.php", "line": 53, "function": "processNextOrFinishSuccessfully", "class": "OC\\Authentication\\Login\\ALoginCommand", "type": "->", "args": [ { "__class__": "OC\\Authentication\\Login\\LoginData" } ] }, { "file": "/usr/local/www/nextcloud/lib/private/Authentication/Login/Chain.php", "line": 108, "function": "process", "class": "OC\\Authentication\\Login\\PreLoginHookCommand", "type": "->", "args": [ { "__class__": "OC\\Authentication\\Login\\LoginData" } ] }, { "file": "/usr/local/www/nextcloud/core/Controller/LoginController.php", "line": 329, "function": "process", "class": "OC\\Authentication\\Login\\Chain", "type": "->", "args": [ { "__class__": "OC\\Authentication\\Login\\LoginData" } ] }, { "file": "/usr/local/www/nextcloud/lib/private/AppFramework/Http/Dispatcher.php", "line": 225, "function": "tryLogin", "class": "OC\\Core\\Controller\\LoginController", "type": "->", "args": [ "*** sensitive parameters replaced ***" ] }, { "file": "/usr/local/www/nextcloud/lib/private/AppFramework/Http/Dispatcher.php", "line": 133, "function": "executeController", "class": "OC\\AppFramework\\Http\\Dispatcher", "type": "->", "args": [ { "__class__": "OC\\Core\\Controller\\LoginController" }, "tryLogin" ] }, { "file": "/usr/local/www/nextcloud/lib/private/AppFramework/App.php", "line": 172, "function": "dispatch", "class": "OC\\AppFramework\\Http\\Dispatcher", "type": "->", "args": [ { "__class__": "OC\\Core\\Controller\\LoginController" }, "tryLogin" ] }, { "file": "/usr/local/www/nextcloud/lib/private/Route/Router.php", "line": 298, "function": "main", "class": "OC\\AppFramework\\App", "type": "::", "args": [ "OC\\Core\\Controller\\LoginController", "tryLogin", { "__class__": "OC\\AppFramework\\DependencyInjection\\DIContainer" }, [ "core.login.tryLogin" ] ] }, { "file": "/usr/local/www/nextcloud/lib/base.php", "line": 1030, "function": "match", "class": "OC\\Route\\Router", "type": "->", "args": [ "/login" ] }, { "file": "/usr/local/www/nextcloud/index.php", "line": 36, "function": "handleRequest", "class": "OC", "type": "::", "args": [] } ], "File": "/usr/local/www/nextcloud/lib/private/Http/Client/LocalAddressChecker.php", "Line": 82 }, "CustomMessage": "--" } } ``` ### Additional info _No response_