Flow with "Or" statements

Multipass · September 11, 2024, 2:58pm

Nextcloud version : 28.0.9
Operating system and version : Linux 6.6.18 aarch64
Apache version : Apache 2.4.62 (Debian)
PHP version : 8.1.29

Is it possible to block access to a file using flag and if a user is not in group X, OR group Y, OR groupe Z ?

I see that the Flow app assume it’s all “and” (see image), I couldn’t find if this could be changed

Flow_and_or1

R0Wi · October 4, 2024, 8:47pm

AFAIK this is currently not possible within the workflow engine. The current implementation just iterates over every check entry. If one check doesn’t succeed, the workflow event is skipped.

To implement this new feature, this code needs to be adjusted:

github.com

nextcloud/server/blob/67e09281e3deb65539182840abee8f4a97cc6ffc/apps/workflowengine/lib/Service/RuleMatcher.php#L158


      
          		$matches = [];
          		foreach ($operations as $operation) {
          			$configuredEvents = json_decode($operation['events'], true);
          			if ($this->eventName !== null && !in_array($this->eventName, $configuredEvents)) {
          				continue;
          			}
          
          			$checkIds = json_decode($operation['checks'], true);
          			$checks = $this->manager->getChecks($checkIds);
          
          			foreach ($checks as $check) {
          				if (!$this->check($check)) {
          					// Check did not match, continue with the next operation
          					continue 2;
          				}
          			}
          
          			$ctx = new LogContext();
          			$ctx
          				->setEntity($this->entity)
          				->setOperation($this->operation)

Maybe you can open a new feature request at Sign in to GitHub · GitHub

PS: as a possible workaround you could try to setup individual workflows per user instead of putting them all together in one workflow? In theory (if you define your checks correctly) only one workflow should trigger at a time.

anon75456558 · October 4, 2024, 9:35pm

Here is the info on Flow - Flow - Apps - App Store - Nextcloud
And here is the repo - https://github.com/cloud-py-api/flow/issues

Interesting to see it has moved from Nextcloud to cloud-py-api.

system · November 22, 2024, 3:02pm

This topic was automatically closed 8 days after the last reply. New replies are no longer allowed.