Dozens of notifications when a shared video is played in the browser

rarbdb · May 8, 2024, 2:51pm

Nextcloud version (eg, 20.0.5): 29.0.0
PHP version (eg, 7.4): 8.2.18

The issue you are facing:
When I share a video via public link and open it I get dozens of notifications. This problem existed and it’s been repaired in 2021, but it returned. Please check this on yours Nextcloud servers, so maybe this is 29 version problem.

github.com/nextcloud/activity

Hundreds of notifications when a shared video is played in the browser

opened 03:16AM - 16 Oct 20 UTC

closed 08:48PM - 07 Mar 22 UTC

melyux

### Steps to reproduce 1. Enable public link download notifications 2. Upload an iPhone video to Nextcloud, so that it ends up with the .mov extension. Share it via public link 3. Go to the public link 4. Play the video 5. Look at all the notifications and have an aneurysm ### Expected behaviour A single notification should be sent, or maybe one when the user visits and another one when they actually download the file ### Actual behaviour I get a notification that the file is being downloaded when I visit the link, then immediately another notification that just says “Nextcloud notification”, and then another one that the file is being downloaded. All before playing the video. Once you press the play button... I start getting about 20 notifications a second, some of them saying the file is being downloaded and others just saying “Nextcloud notification” for some reason. ### Server configuration  **Operating system**: Linux (Docker) **Web server:** Not sure **Database:** MySQL (MariaDB) 10.5.5 **PHP version:** 7.3.2.3 **Nextcloud version:** (see Nextcloud admin page) 20.0.0 **Where did you install Nextcloud from:** Docker **Signing status:** ``` No errors have been found. ``` **List of activated apps:** ``` Enabled: - activity: 2.13.1 - bruteforcesettings: 2.0.1 - cloud_federation_api: 1.3.0 - comments: 1.10.0 - contactsinteraction: 1.1.0 - dav: 1.16.0 - federatedfilesharing: 1.10.1 - files: 1.15.0 - files_downloadactivity: 1.9.0 - files_external: 1.11.1 - files_pdfviewer: 2.0.1 - files_rightclick: 0.17.0 - files_sharing: 1.12.0 - files_trashbin: 1.10.1 - files_versions: 1.13.0 - files_videoplayer: 1.9.0 - logreader: 2.5.0 - lookup_server_connector: 1.8.0 - notes: 4.0.0 - notifications: 2.8.0 - oauth2: 1.8.0 - password_policy: 1.10.1 - photos: 1.2.0 - provisioning_api: 1.10.0 - serverinfo: 1.10.0 - settings: 1.2.0 - text: 3.1.0 - theming: 1.11.0 - twofactor_backupcodes: 1.9.0 - twofactor_nextcloud_notification: 3.0.0 - twofactor_totp: 5.0.0 - updatenotification: 1.10.0 - user_status: 1.0.0 - viewer: 1.4.0 - workflowengine: 2.2.0 Disabled: - accessibility - admin_audit - dashboard - encryption - federation - firstrunwizard - nextcloud_announcements - privacy - recommendations - sharebymail - support - survey_client - systemtags - tasks - user_ldap - weather_status ``` **Nextcloud configuration:** ``` { "system": { "memcache.local": "\\OC\\Memcache\\APCu", "datadirectory": "***REMOVED SENSITIVE VALUE***", "instanceid": "***REMOVED SENSITIVE VALUE***", "passwordsalt": "***REMOVED SENSITIVE VALUE***", "secret": "***REMOVED SENSITIVE VALUE***", "trusted_domains": [ "nextcloud.***.com" ], "trusted_proxies": "***REMOVED SENSITIVE VALUE***", "dbtype": "mysql", "version": "20.0.0.9", "overwrite.cli.url": "https:\/\/nextcloud.***.com", "dbname": "***REMOVED SENSITIVE VALUE***", "dbhost": "***REMOVED SENSITIVE VALUE***", "dbport": "", "dbtableprefix": "oc_", "mysql.utf8mb4": true, "dbuser": "***REMOVED SENSITIVE VALUE***", "dbpassword": "***REMOVED SENSITIVE VALUE***", "installed": true, "maintenance": false, "twofactor_enforced": "false", "twofactor_enforced_groups": [], "twofactor_enforced_excluded_groups": [], "updater.secret": "***REMOVED SENSITIVE VALUE***", "theme": "", "loglevel": 2, "updater.release.channel": "stable" }, "apps": { "accessibility": { "enabled": "no", "installed_version": "1.2.0", "types": "" }, "activity": { "enable_email": "no", "enabled": "yes", "installed_version": "2.13.1", "types": "filesystem" }, "backgroundjob": { "lastjob": "1982" }, "bruteForce": { "whitelist_1": "*.*.*.*\/0" }, "bruteforcesettings": { "enabled": "yes", "installed_version": "2.0.1", "types": "" }, "cloud_federation_api": { "enabled": "yes", "installed_version": "1.3.0", "types": "filesystem" }, "comments": { "enabled": "yes", "installed_version": "1.10.0", "types": "logging" }, "contactsinteraction": { "enabled": "yes", "installed_version": "1.1.0", "types": "dav" }, "core": { "backgroundjobs_mode": "cron", "enterpriseLogoChecked": "yes", "installed.bundles": "[\"CoreBundle\"]", "installedat": "1568505563.6541", "lastcron": "1602817500", "lastupdateResult": "[]", "lastupdatedat": "1602816663", "oc.integritycheck.checker": "[]", "public_files": "files_sharing\/public.php", "public_webdav": "dav\/appinfo\/v1\/publicwebdav.php", "shareapi_exclude_groups": "no", "shareapi_exclude_groups_list": "[\"\"]", "shareapi_only_share_with_group_members": "no", "theming.variables": "f2b95d7611988ad39c523e206a9126ac", "updater.secret.created": "1602789790", "vendor": "nextcloud" }, "dashboard": { "enabled": "no", "installed_version": "7.0.0", "types": "" }, "dav": { "buildCalendarReminderIndex": "yes", "buildCalendarSearchIndex": "yes", "chunks_migrated": "1", "enabled": "yes", "installed_version": "1.16.0", "regeneratedBirthdayCalendarsForYearFix": "yes", "types": "filesystem" }, "deck": { "enabled": "no", "installed_version": "0.6.6", "types": "dav" }, "federatedfilesharing": { "enabled": "yes", "installed_version": "1.10.1", "types": "" }, "federation": { "enabled": "no", "installed_version": "1.6.0", "types": "authentication" }, "files": { "cronjob_scan_files": "500", "enabled": "yes", "installed_version": "1.15.0", "types": "filesystem" }, "files_downloadactivity": { "enabled": "yes", "installed_version": "1.9.0", "types": "filesystem" }, "files_external": { "enabled": "yes", "installed_version": "1.11.1", "types": "filesystem" }, "files_pdfviewer": { "enabled": "yes", "installed_version": "2.0.1", "types": "" }, "files_rightclick": { "enabled": "yes", "installed_version": "0.17.0", "types": "" }, "files_sharing": { "enabled": "yes", "installed_version": "1.12.0", "types": "filesystem" }, "files_texteditor": { "enabled": "no", "installed_version": "2.14.0", "types": "" }, "files_trackdownloads": { "enabled": "no", "installed_version": "1.9.0", "types": "filesystem" }, "files_trashbin": { "enabled": "yes", "installed_version": "1.10.1", "types": "filesystem,dav" }, "files_versions": { "enabled": "yes", "installed_version": "1.13.0", "types": "filesystem,dav" }, "files_videoplayer": { "enabled": "yes", "installed_version": "1.9.0", "types": "" }, "firstrunwizard": { "enabled": "no", "installed_version": "2.5.0", "types": "logging" }, "gallery": { "enabled": "no", "installed_version": "18.4.0", "types": "" }, "logreader": { "enabled": "yes", "installed_version": "2.5.0", "types": "" }, "lookup_server_connector": { "enabled": "yes", "installed_version": "1.8.0", "types": "authentication" }, "nextcloud_announcements": { "enabled": "no", "installed_version": "1.5.0", "pub_date": "Mon, 02 Sep 2019 00:00:00 +0200", "types": "logging" }, "notes": { "enabled": "yes", "installed_version": "4.0.0", "types": "" }, "notifications": { "enabled": "yes", "installed_version": "2.8.0", "types": "logging" }, "oauth2": { "enabled": "yes", "installed_version": "1.8.0", "types": "authentication" }, "password_policy": { "enabled": "yes", "installed_version": "1.10.1", "types": "authentication" }, "photos": { "enabled": "yes", "installed_version": "1.2.0", "types": "" }, "privacy": { "enabled": "no", "installed_version": "1.0.0", "types": "" }, "provisioning_api": { "enabled": "yes", "installed_version": "1.10.0", "types": "prevent_group_restriction" }, "recommendations": { "enabled": "no", "installed_version": "0.4.0", "types": "" }, "serverinfo": { "enabled": "yes", "installed_version": "1.10.0", "types": "" }, "settings": { "enabled": "yes", "installed_version": "1.2.0", "types": "" }, "sharebymail": { "enabled": "no", "installed_version": "1.6.0", "types": "filesystem" }, "spreed": { "enabled": "no", "installed_version": "6.0.4", "signaling_ticket_secret": "***REMOVED SENSITIVE VALUE***", "stun_servers": "***REMOVED SENSITIVE VALUE***", "types": "prevent_group_restriction" }, "support": { "enabled": "no", "installed_version": "1.0.0", "types": "" }, "survey_client": { "enabled": "no", "installed_version": "1.4.0", "types": "" }, "systemtags": { "enabled": "no", "installed_version": "1.6.0", "types": "logging" }, "tasks": { "enabled": "no", "installed_version": "0.13.4", "types": "" }, "text": { "enabled": "yes", "installed_version": "3.1.0", "types": "dav" }, "theming": { "cachebuster": "18", "color": "#0098EB", "enabled": "yes", "faviconMime": "image\/png", "installed_version": "1.11.0", "logoMime": "image\/png", "logoheaderMime": "image\/png", "name": "\u00fc", "slogan": "***REMOVED SENSITIVE VALUE***", "types": "logging", "url": "***REMOVED SENSITIVE VALUE***" }, "twofactor_backupcodes": { "enabled": "yes", "installed_version": "1.9.0", "types": "" }, "twofactor_nextcloud_notification": { "enabled": "yes", "installed_version": "3.0.0", "***_enabled": "1", "***_enabled": "1", "***": "" }, "twofactor_totp": { "enabled": "yes", "installed_version": "5.0.0", "types": "" }, "updatenotification": { "core": "18.0.10.2", "enabled": "yes", "files_rightclick": "0.15.1", "installed_version": "1.10.0", "types": "", "update_check_errors": "0" }, "uploaddetails": { "enabled": "no", "installed_version": "0.1.3", "types": "" }, "user_status": { "enabled": "yes", "installed_version": "1.0.0", "types": "" }, "viewer": { "enabled": "yes", "installed_version": "1.4.0", "types": "" }, "weather_status": { "enabled": "no", "installed_version": "1.0.0", "types": "" }, "workflowengine": { "enabled": "yes", "installed_version": "2.2.0", "types": "filesystem" } } } ``` **Are you using an external user-backend, if yes which one:** LDAP/ActiveDirectory/Webdav/... ### Client configuration **Browser:** All **Operating system:** All ### Logs #### Nextcloud log (data/nextcloud.log) ``` No new messages when this happens ``` #### Browser log

github.com/nextcloud/activity

Shared videos count multiple times

opened 03:58PM - 04 Mar 19 UTC

closed 08:48PM - 07 Mar 22 UTC

NickCloudAT

bug

### Steps to reproduce 1. Share video with public link 2. Click on that link 3. Look at activitys ### Expected behaviour Should show that it was watched once ### Actual behaviour For me, it shows 3 times downloaded, even tough it was only 1 person clicking on the link ### Server configuration  **Operating system**: Ubuntu 16.04 **Web server:** Apache2 **Database:** MySQL **PHP version:**Php7.2 **Nextcloud version:** Newest 15.0.5 **Where did you install Nextcloud from:** Official nextcloud page List of activated apps: https://pastebin.com/KknLGgD4 Config: https://pastebin.com/dcf5TZGw

Is this the first time you’ve seen this error? (Y/N):Y

Steps to replicate it:

Share a video via public link
Open the video from link
Check notifications

jtr · May 8, 2024, 7:58pm

How big is the time gap between the “downloaded via public link” entries?

github.com

nextcloud/server/blob/72470e33be052ef7803e9fff944da0dec9042755/lib/private/Activity/EventMerger.php#L55-L63


      
          	 * The following requirements have to be met, in order to be merged:
          	 * - Both events need to have the same `getApp()`
          	 * - Both events must not have a message `getMessage()`
          	 * - Both events need to have the same subject `getSubject()`
          	 * - Both events need to have the same object type `getObjectType()`
          	 * - The time difference between both events must not be bigger then 3 hours
          	 * - Only up to 5 events can be merged.
          	 * - All parameters apart from such starting with $mergeParameter must be
          	 *   the same for both events.

rarbdb · May 8, 2024, 8:50pm

Approx. 1 second.

rarbdb · May 8, 2024, 9:25pm

If you have the same version, please check this on your server, maybe it’s not only mine problem.