Nextcloud Docker - overwritecondaddr not working!

ToniToga · August 19, 2022, 10:02am

Hello my Friends,
I have some trouble to get a Nextcloud Docker instance working.
The Problem is, that I need to rewrite the Host Address.
Therefore I dicovered the overwritehost parameter which I configured in the config.php. This is working well, but I need to limit the overwritehost parameter to a specific IP-Address. Therefore I discovered the overwritecondaddr parameter.
But this Parameter is not working at all. When I configure the overwritecondaddr, The Address is still getting overwritten everytime. I already checked and tried every kind of spelling.

It’s exactly the same issue like this one here, explained at GitHub, but I didn’t understood the workaround!

github.com/nextcloud/server

Config Param 'overwritecondaddr' not working

opened 01:11PM - 23 Oct 17 UTC

ghmax

bug 1. to develop

### Steps to reproduce 1. clean install nextcloud 2. add conditional overwrite settings to config.php 'overwritehost' => 'my.domain.com', 'overwritecondaddr' => '^192\.168\.0\.1$', ### Expected behaviour Hostname should be overwritten when request comes in via 192.168.0.1, otherwise NOT. ### Actual behaviour Hostname is always overwritten ### Server configuration **Operating system**: official Docker Image on different Docker Hosts **Nextcloud version:** (see Nextcloud admin page) 12.0.3.3 **Updated from an older Nextcloud/ownCloud or fresh install:** fresh **Where did you install Nextcloud from:** docker **Nextcloud configuration:** <details> <summary>Config report</summary> ``` <?php $CONFIG = array ( 'htaccess.RewriteBase' => '/', 'memcache.local' => '\\OC\\Memcache\\APCu', 'apps_paths' => array ( 0 => array ( 'path' => '/var/www/html/apps', 'url' => '/apps', 'writable' => false, ), 1 => array ( 'path' => '/var/www/html/custom_apps', 'url' => '/custom_apps', 'writable' => true, ), ), 'instanceid' => 'xxx', 'passwordsalt' => 'xxx', 'secret' => 'xxx', 'trusted_domains' => array ( 0 => '192.168.99.100:9000', ), 'datadirectory' => '/var/www/html/data', 'overwrite.cli.url' => 'http://192.168.99.100:9000', 'dbtype' => 'sqlite3', 'version' => '12.0.3.3', 'installed' => true, 'overwritecondaddr' => '^192\.168\.99\.11$', 'overwritehost' => 'my.domain.com', ); ``` </details> ### Code causing Troubles... Problem is in File .../lib/private/AppFramework/Http/Request.php in Method 'private function isOverwriteCondition($type = '')' ... type is empty when checking for e.g. Host-Override in Method 'getOverwriteHost' ... so with empty type check override method (isOverwriteCondition) always returns true cause of: ... return $regex === '//' || preg_match($regex, $remoteAddr) === 1 || $type !== 'protocol'; ... -> type === '' ... so $type !== 'protocol' is always true ... so method always returns true in this case.

Does anyone know how to solve this Problem?

wwe · August 19, 2022, 3:54pm

If I get you right you want to overwrite the hostname only in case the request comes from specific IP e.g. your router? At least this is a problem described at GH. The solution there was to slightly to change the code of lib/private/AppFramework/Http/Request.php

But maybe you are heading the wrong way? usually if you publish your Nextcloud externally it runs behind reverse proxy with TLS certificate - accessing the instance from local LAN using local hostname or IP will result in TLS warnings (additionally sharing is broken as you can’t share internal address to external users). In this case best solution would be to always access application using external FQDN inside and outside your network (there are solutions to avoid going through internet - search split-bran DNS, split-horizon DNS, rebind protection). Additional benefit of such config is you always hit exactly the same access path - troubleshooting becomes much easier.

ToniToga · August 27, 2022, 9:34pm

Thanks wwe, your helped me a lot. I will have a look how to make these changes to my docker enviroment.

You are absolutly right, in most cases this would be the wrong way, but in my case I think I’ve no choice.
I want to use a proxy-serverconnection. The Endpoint in America has a different Domainname than the Endpoint in Germany. Thats the Background. I already tried to configure my reverseproxy to handle this, but this wasn’t working, so for now I’m heading to the Nextcloudconfiguration