Nextcloud app Docker entrypoint script improved! code review needed

ℹ️ Support 📦 Appliances (Docker, Snappy, VM, NCP, AIO)
1

I’m looking for code review and testing help with Use flock for the upgrade lock by remram44 · Pull Request #1905 · nextcloud/docker · GitHub . Anyone able to assist? I think it would be great to get this patch in for more resilient upgrades, especially for folks that run multiple Nextcloud app Docker containers.

review

This is where we need the most help.

The changes are all in Bash script. It looks like many files are changed, but really it is just one file: docker-entrypoint.sh. The changes in that file are propagated to all others.

test

To test requires some familiarity with Docker. The basic test steps are in Add `NEXTCLOUD_INIT_LOCK` to enable shared html volume update by skjnldsv · Pull Request #1760 · nextcloud/docker · GitHub , they just need slight adjustment because the version is 25 and the NEXTCLOUD_INIT_LOCK environment variable is now gone, so that can be left out. I’ll update the test procedure if I can make time for that.

Thanks! -Adam

See also