Ncp-dist-upgrade to buster broke nc-snapshot-auto on my installation (renegade)

Hello,

Last week I upgraded to buster with ncp-dist-upgrade. I have edited a few of the cron scripts to also ping my healthchecks.io instance. The health-checks related to /etc/cron.hourly/btrfs-snp started failing after the upgrade. It seems that /usr/local/bin/btrfs-snp did not update to the latest version that is buster compatible (according to btrfs-snp. After I manually updated the script, it started working again.

Is this because I edited the cron scripts; Have you noticed anything similar after you upgraded to buster?

Best regards,

Panos

System information

NextCloudPi diagnostics

NextCloudPi version  v1.20.7
NextCloudPi image    NextCloudPi_01-17-19
distribution         Debian GNU/Linux 10 \n \l
automount            yes
USB devices          sda sdb 
datadir              /media/nextcloud/ncdata
data in SD           no
data filesystem      btrfs
data disk usage      376G/800G
rootfs usage         6.7G/29G
swapfile             /var/swap
dbdir                /media/nextcloud/ncdatabase
Nextcloud check      ok
Nextcloud version    17.0.2.1
HTTPD service        up
PHP service          up
MariaDB service      up
Redis service        up
Postfix service      up
internet check       ok
port check 80        open
port check 443       open
IP                   ***REMOVED SENSITIVE VALUE***
gateway              ***REMOVED SENSITIVE VALUE***
interface            eth0
certificates         ***REMOVED SENSITIVE VALUE***
NAT loopback         no
uptime               4:21

Nextcloud configuration

{
    "system": {
        "passwordsalt": "***REMOVED SENSITIVE VALUE***",
        "secret": "***REMOVED SENSITIVE VALUE***",
        "trusted_domains": {
            "0": "localhost",
            "5": "nextcloudpi.local",
            "7": "nextcloudpi",
            "8": "nextcloudpi.lan",
            "1": "192.168.1.167",
            "4": "leontiou.hopto.org",
            "11": "77.49.255.42",
            "20": "leontiou.hopto.org",
            "21": "nextcloudpi.local",
            "22": "192.168.1.167"
        },
        "datadirectory": "***REMOVED SENSITIVE VALUE***",
        "dbtype": "mysql",
        "version": "17.0.2.1",
        "overwrite.cli.url": "https:\/\/192.168.1.167\/",
        "dbname": "***REMOVED SENSITIVE VALUE***",
        "dbhost": "***REMOVED SENSITIVE VALUE***",
        "dbport": "",
        "dbtableprefix": "oc_",
        "mysql.utf8mb4": true,
        "dbuser": "***REMOVED SENSITIVE VALUE***",
        "dbpassword": "***REMOVED SENSITIVE VALUE***",
        "installed": true,
        "instanceid": "***REMOVED SENSITIVE VALUE***",
        "memcache.local": "\\OC\\Memcache\\Redis",
        "memcache.locking": "\\OC\\Memcache\\Redis",
        "redis": {
            "host": "***REMOVED SENSITIVE VALUE***",
            "port": 0,
            "timeout": 0,
            "password": "***REMOVED SENSITIVE VALUE***"
        },
        "tempdirectory": "\/media\/nextcloud\/ncdata\/tmp",
        "mail_smtpmode": "smtp",
        "mail_smtpauthtype": "PLAIN",
        "mail_from_address": "***REMOVED SENSITIVE VALUE***",
        "mail_domain": "***REMOVED SENSITIVE VALUE***",
        "overwriteprotocol": "https",
        "maintenance": false,
        "logfile": "\/media\/nextcloud\/ncdata\/nextcloud.log",
        "loglevel": "2",
        "log_type": "file",
        "jpeg_quality": "60",
        "app_install_overwrite": [
            "mail"
        ],
        "mail_sendmailmode": "smtp",
        "mail_smtpsecure": "tls",
        "mail_smtphost": "***REMOVED SENSITIVE VALUE***",
        "mail_smtpport": "25",
        "mail_smtpauth": 1,
        "mail_smtpname": "***REMOVED SENSITIVE VALUE***",
        "mail_smtppassword": "***REMOVED SENSITIVE VALUE***",
        "preview_max_x": "2048",
        "preview_max_y": "2048",
        "theme": ""
    }
}

HTTPd logs

[Mon Feb 24 00:00:03.121335 2020] [ssl:warn] [pid 2650:tid 548492449136] AH01909: localhost:4443:0 server certificate does NOT include an ID which matches the server name
[Mon Feb 24 00:00:03.139515 2020] [mpm_event:notice] [pid 2650:tid 548492449136] AH00489: Apache/2.4.38 (Debian) OpenSSL/1.1.1d configured -- resuming normal operations
[Mon Feb 24 00:00:03.139594 2020] [core:notice] [pid 2650:tid 548492449136] AH00094: Command line: '/usr/sbin/apache2'
[Mon Feb 24 12:56:53.854859 2020] [mpm_event:notice] [pid 2650:tid 548492449136] AH00491: caught SIGTERM, shutting down
[Mon Feb 24 12:57:55.054228 2020] [ssl:warn] [pid 2595:tid 547577288048] AH01909: localhost:4443:0 server certificate does NOT include an ID which matches the server name
[Mon Feb 24 12:57:55.098225 2020] [ssl:warn] [pid 2650:tid 547577288048] AH01909: localhost:4443:0 server certificate does NOT include an ID which matches the server name
[Mon Feb 24 12:57:55.104134 2020] [mpm_event:notice] [pid 2650:tid 547577288048] AH00489: Apache/2.4.38 (Debian) OpenSSL/1.1.1d configured -- resuming normal operations
[Mon Feb 24 12:57:55.104280 2020] [core:notice] [pid 2650:tid 547577288048] AH00094: Command line: '/usr/sbin/apache2'

Database logs

2020-02-24 12:57:47 0 [Note] InnoDB: Compressed tables use zlib 1.2.11
2020-02-24 12:57:47 0 [Note] InnoDB: Number of pools: 1
2020-02-24 12:57:47 0 [Note] InnoDB: Using generic crc32 instructions
2020-02-24 12:57:47 0 [Note] InnoDB: Initializing buffer pool, total size = 896M, instances = 1, chunk size = 128M
2020-02-24 12:57:47 0 [Note] InnoDB: Completed initialization of buffer pool
2020-02-24 12:57:47 0 [Note] InnoDB: If the mysqld execution user is authorized, page cleaner thread priority can be changed. See the man page of setpriority().
2020-02-24 12:57:47 0 [Note] InnoDB: 128 out of 128 rollback segments are active.
2020-02-24 12:57:47 0 [Note] InnoDB: Creating shared tablespace for temporary tables
2020-02-24 12:57:47 0 [Note] InnoDB: Setting file './ibtmp1' size to 12 MB. Physically writing the file full; Please wait ...
2020-02-24 12:57:48 0 [Note] InnoDB: File './ibtmp1' size is now 12 MB.
2020-02-24 12:57:48 0 [Note] InnoDB: Waiting for purge to start
2020-02-24 12:57:48 0 [Note] InnoDB: 10.3.22 started; log sequence number 7427788229; transaction id 168199512
2020-02-24 12:57:48 0 [Note] InnoDB: Loading buffer pool(s) from /media/nextcloud/ncdatabase/ib_buffer_pool
2020-02-24 12:57:48 0 [Note] Plugin 'FEEDBACK' is disabled.
2020-02-24 12:57:48 0 [Note] Server socket created on IP: '127.0.0.1'.
2020-02-24 12:57:48 0 [Note] Reading of all Master_info entries succeeded
2020-02-24 12:57:48 0 [Note] Added new Master_info '' to hash table
2020-02-24 12:57:48 0 [Note] /usr/sbin/mysqld: ready for connections.
Version: '10.3.22-MariaDB-0+deb10u1'  socket: '/var/run/mysqld/mysqld.sock'  port: 3306  Debian 10
2020-02-24 12:57:49 0 [Note] InnoDB: Buffer pool(s) load completed at 200224 12:57:49

Nextcloud logs

Hard for anyone to say, without seeing the edits…very likely you broke something, as nobody else reported any problems with nc-snapshot-auto after the update to Buster.

Hello again @OliverV and thanks for the quick reply.

The thing is I only edited the cron/anacron scripts and didn’t touch /usr/local/bin/btrfs-snp. This is were I got the error from ("$DIR is not a BTRFS mountpoint or snapshot") and then noticed the fix for buster which was committed last summer.

As far as I have understood update.sh, it only calls install_app on new apps (line 86) and this explains why ncp-snapshot-auto of my installation was never updated and thus /usr/local/bin/btrfs-snp was kept to the version from the NCP installation (before the aforementioned btrfs-snp commit that supports buster) .

Are your NCP installations earlier than 25/07/2019 (the day of the commit/fix)? Is /usr/local/bin/btrfs-snp updated to the latest version? As fas as i can understand, the only way that the pre 25/07/2019 version can work in buster is if you save the snapshots in the root of the btrfs partition.

Again thanks for the support and your time.

Best regards,

Panos