Logged in user must be an admin

sebastiank · August 7, 2023, 9:02pm

Hi Everyone,

I am developing an app for the community, and I was going to wait on revealing it until, it was on the app store but while doing some final testing, I’ve seem to have hit a snag to which I cannot find any information on.

The app works as expected as Admin, but when I try to use it as another user I get a “Logged in user must be an admin” error. This is while trying to save the initial configuration of the app in the user settings section. The odd thing is that this error occurs even before the Connect() controller method even fires.

Here is a link to the controller code,

github.com

ksainc/integration_ews/blob/main/lib/Controller/UserConfigurationController.php

<?php
declare(strict_types=1);

/**
* @copyright Copyright (c) 2023 Sebastian Krupinski <krupinski01@gmail.com>
*
* @author Sebastian Krupinski <krupinski01@gmail.com>
*
* @license AGPL-3.0-or-later
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU Affero General Public License as
* published by the Free Software Foundation, either version 3 of the
* License, or (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
* GNU Affero General Public License for more details.
*

This file has been truncated. show original

So how do I figure out what the issue is?

Thanks in advance
Sebastian

christianlupus · August 7, 2023, 9:09pm

I guess from your description without looking at the code in depth, that you are missing the annotation@NoAdminRequired. With the more recent Nextcloud core versions, you can use attributes as well. This is a security feature that you must in fact loosen the restrictions. See Controllers — Nextcloud latest Developer Manual latest documentation

sebastiank · August 7, 2023, 9:40pm

Hi christianlupus,

Thank you for the quick response!

That was the issue!

After adding @NoAdminRequired to all the methods in the controller class everything is working as it should again!

Sebastian